Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change/api funcs #118

Merged
merged 15 commits into from
May 24, 2024
Merged

Change/api funcs #118

merged 15 commits into from
May 24, 2024

Conversation

bakhterets
Copy link
Contributor

separating changes to the API from the "aware datetime" branch

@bakhterets
Copy link
Contributor Author

image
image

@Aloento
Copy link
Member

Aloento commented Apr 30, 2024

Still Draft

@bakhterets bakhterets added enhancement New feature or request api API labels May 2, 2024
@@ -81,7 +81,7 @@ <h6>{{ update.status }}</h6>
<small>{{ update.timestamp.strftime('%Y-%m-%d %H:%M') }}&nbsp;UTC</small>
</div>
<div class="col-md-10">
{{ update.text }}
{{ update.text|safe }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space?

link_s = f"<a href='{url_d}'>{dst_incident.text}</a>"
link_d = f"<a href='{url_s}'>{src_incident.text}</a>"
update_s = f"{comp_with_attrs} moved to {link_s}"
update_d = f"{comp_with_attrs} moved from {link_d}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during testing I don't see the details only the strings moved to and moved from
image

@vladimirhasko
Copy link
Contributor

The issue has been detected when the component is split/created to new incident on UI frontend (without API)
then the empty moved to and moved from message appears as seen on screenshots

@bakhterets bakhterets marked this pull request as ready for review May 22, 2024 09:09
@bakhterets bakhterets requested a review from vladimirhasko May 22, 2024 15:20
@bakhterets bakhterets added the gate Gate PR with Zuul label May 24, 2024
Copy link

otc-zuul bot commented May 24, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/a524d510113643a1b9fd62303362ed70

✔️ otc-tox-docs SUCCESS in 9m 30s
✔️ otc-tox-pep8 SUCCESS in 4m 42s
✔️ stackmon-status-dashboard-upload-image SUCCESS in 3m 09s

@otc-zuul otc-zuul bot merged commit 9547f1b into main May 24, 2024
5 checks passed
@otc-zuul otc-zuul bot deleted the change/api_funcs branch May 24, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API enhancement New feature or request gate Gate PR with Zuul
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants